Skip to content

Icon cache and Task.Run tweaks #9885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 4, 2022
Merged

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented Sep 3, 2022

Details of Changes
Add details of changes here.

  • Introduced a cache for icon and overlay
  • Avoid using Task.Run for long-running tasks

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

yaira2
yaira2 previously approved these changes Sep 4, 2022
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 4, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit a8cb8b2 into files-community:main Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants