Skip to content

Add cast from IDictionary to ConcurrentDictionary #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2022
Merged

Add cast from IDictionary to ConcurrentDictionary #9810

merged 1 commit into from
Aug 25, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Aug 25, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Closes Appcenter 2855768364u

Details of Changes
Add details of changes here.

  • Calling Add() on a ConcurrentDictionary cast to IDictionary breaks concurrency. Need to cast it to ConcurrentDictionary and call TryAdd explicitly.

Validation
How did you test these changes?

  • Built and ran the app

yaira2
yaira2 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 25, 2022
@yaira2 yaira2 merged commit 5116b03 into files-community:main Aug 25, 2022
@gave92 gave92 deleted the 2855768364u branch August 25, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2