Skip to content

Move tags to a sub menu flyout #9777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 21, 2022
Merged

Move tags to a sub menu flyout #9777

merged 11 commits into from
Aug 21, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Aug 20, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Moved tags to a standard sub menu flyout
  • Moved MenuFlyoutItemWithImage to Menus folder
  • Small refactor of MenuFlyoutHelper

Validation
How did you test these changes?

  • Built and ran the app

Screenshots (optional)

@gave92 gave92 marked this pull request as draft August 20, 2022 17:51
@gave92
[WIP]
c31dbcc 
Set tag color for label
@gave92 gave92 marked this pull request as ready for review August 20, 2022 18:45
@yaira2 yaira2 self-requested a review August 21, 2022 04:29
@gave92 gave92 marked this pull request as draft August 21, 2022 17:32
gave92 added 4 commits August 21, 2022 20:35
@gave92
Revert "[WIP]"
95db4ef 
Move MenuFlyoutItemWithImage to Menus folder
Funny stuff with xaml
@gave92
Revert "Funny stuff with xaml"
7986154 
Make use of MenuFlyoutHelper
@gave92
Remove constructors, add template item
0d004b5 
Rename and move definition of MenuFlyoutItemPathViewModel
Move MenuFlyoutItemViewModel to its own file
@gave92
Revert "Move MenuFlyoutItemViewModel to its own file"
9ef6e2a 
Add CommandParameter and Tooltip props to MenuFlyoutItemViewModel
@gave92 gave92 marked this pull request as ready for review August 21, 2022 19:54
yaira2
yaira2 reviewed Aug 21, 2022
View reviewed changes
yaira2
yaira2 previously approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 21, 2022
@yaira2 yaira2 merged commit d827a32 into files-community:main Aug 21, 2022
@gave92 gave92 deleted the tags_menu branch August 22, 2022 08:05
@files-community files-community deleted a comment from gave92 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move tags to a sub menu flyout in the right click context menu so that users can see the tag name
2 participants
@gave92 @yaira2