Skip to content

Fix - Selecting a tag on the sidebar doesn't highlight it #9766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Details of Changes

  • Added an 'if' that checks if the selected item is a FileTagItem and if true sets it as the path to highlight

Validation

  • Built and ran the app

Screenshots
Screenshot (26)

@gave92
Copy link
Member

gave92 commented Aug 20, 2022

Nice one, thanks! I just added a null check b/c when you do a normal search NavPathParam is null.

@gave92 gave92 added the ready to merge Pull requests that are approved and ready to merge label Aug 20, 2022
@gave92 gave92 self-requested a review August 20, 2022 13:17
gave92
gave92 previously approved these changes Aug 20, 2022
@yaira2 yaira2 changed the title Fix - Selecting a tag on the sidebar doesn't highlight it #9760 Fix - Selecting a tag on the sidebar doesn't highlight it Aug 21, 2022
@yaira2
Copy link
Member

yaira2 commented Aug 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2 yaira2 merged commit fa481b0 into files-community:main Aug 21, 2022
@ferrariofilippo ferrariofilippo deleted the Fix-Selecting_Tag_Doesn't_Highlight_It branch September 12, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting a tag on the sidebar doesn't highlight it
3 participants