Feature: Enabled tags by default and removed option to turn them off #9710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2dyno1
requested review from
gave92 and
yaira2
and removed request for
gave92
|
As noted in the issue, we're not ready to merge this just yet, let's keep this open in the meantime. |
yaira2
reviewed
Aug 14, 2022
yaira2
reviewed
Aug 14, 2022
yaira2
reviewed
Aug 14, 2022
yaira2
reviewed
Aug 17, 2022
Revert - Removed faulty features Moved to other PR - Hide Tag Column
yaira2
reviewed
Aug 17, 2022
yaira2
reviewed
Aug 17, 2022
yaira2
reviewed
Aug 17, 2022
yaira2
reviewed
Aug 17, 2022
yaira2
reviewed
Aug 17, 2022
yaira2
reviewed
Aug 17, 2022
yaira2
reviewed
Aug 18, 2022
yaira2
reviewed
Aug 18, 2022
yaira2
reviewed
Aug 18, 2022
yaira2
reviewed
Aug 18, 2022
yaira2
reviewed
Aug 18, 2022
|
@ferrariofilippo last thing, can you add the link icon back to the edit button? It should look like this. |
|
Ok, I fixed it |
yaira2
added
needs - code review
and removed
changes requested
yaira2
reviewed
Aug 18, 2022
yaira2
reviewed
Aug 18, 2022
yaira2
reviewed
Aug 18, 2022
yaira2
reviewed
Aug 18, 2022
yaira2
changed the title
yaira2
changed the title
yaira2
added
ready to merge
|
@ferrariofilippo excellent work! Thank you for contributing to Files, this change will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Resolved
Details of Changes
-Removed Tag ToggleSwitch
-Removed all the code that was executed at change of the toggle status
-Removed all the ifs that checked if tags were enabled (Now their code is always executed)
Validation