Skip to content

Create project Files.Filesystem #9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

cinqmilleans
Copy link
Contributor

This pr add the new project Files.Filesystem and some helpers. This pr is part of a larger refactor, cut out for ease.

  • Added project Files.Filesystem
  • Move ILocalizationService to Shared (necessary).
  • Move CommonPath and PathNormalization and FtpHelpers and EnumConversionHelpers.
  • Helpers are improved (style, name, extension, ...). This simplifies calls.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@files-community files-community deleted a comment from Tosdr69 Aug 12, 2022
Copy link

@Fl436341 Fl436341 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/Files.Filesystem/Helpers/CommonPaths.cs

@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
@files-community files-community deleted a comment from Fl436341 Aug 19, 2022
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Files.Uwp/Views/MainPage.xaml.cs around L95

Can you change "GetLocalized" to "GetLocalizedResource" to fix automation build errors?

@yaira2 yaira2 closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants