Feature: Prompt users to review Files #9475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
commented
Jun 28, 2022
gave92
reviewed
Jun 29, 2022
src/Files.Uwp/ServicesImplementation/Settings/ApplicationSettingsService.cs
Show resolved
Hide resolved
|
@yaichenbaum i wont be home till next week. Feel free to assign this to someone else. Code looks good to me, but for the doubts above. |
hez2010
reviewed
Jul 7, 2022
|
Hi guys
Hope you enjoy Github I am new to the world of programming but I can see
that you are doing good work enjoy practice makes it perfect☺
Thank you
Ester
…On Thu, 7 Jul 2022 15:26 Steve, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Files.Uwp/Strings/en-US/Resources.resw
<#9475 (comment)>
:
> @@ -2789,4 +2789,10 @@ We use App Center to track which settings are being used, find bugs, and fix cra
<data name="ShowAlternateStreams" xml:space="preserve">
<value>Show Alternate Data Streams</value>
</data>
+ <data name="ReviewFiles" xml:space="preserve">
+ <value>Review Files</value>
+ </data>
+ <data name="ReviewFilesContent" xml:space="preserve">
+ <value>Would you like to review Files?</value>
I think it can be changed to something like "Do you enjoy using Files? You
can rate Files in the Microsoft Store if you like."
—
Reply to this email directly, view it on GitHub
<#9475 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZO233TSS6SWZLU4OQQHIVTVS3LINANCNFSM52D2B6GA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of Changes
Users who have opened the app more than 10 times will be prompted to review Files in the Microsoft Store. This prompt will only show once and will not come up again unless the app is reset or reinstalled.
Validation
How did you test these changes?