Skip to content

Fix issues with Sideload solution config #9469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2022
Merged

Fix issues with Sideload solution config #9469

merged 1 commit into from
Jun 26, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jun 26, 2022 •
edited
Loading

Noticed a couple fo strange things in the Sideload configuration.

Details of Changes
Add details of changes here.

  • Removed Deploy from Files.Uwp project in Sideload config. Only Files.Package should be deployed, right?
  • Also changed Sideload to build for "arm64" instead of "Any CPU" to match Release config
  • Changed OpenFileDialog project to compile in Release mode when in Sideload config (unimportant)

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested a review from yaira2 June 26, 2022 11:21
yaira2
yaira2 approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Wish it was easier to create new configs 😆

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 26, 2022
@yaira2 yaira2 merged commit 12aa6eb into files-community:main Jun 26, 2022
@gave92 gave92 deleted the fix_sln branch June 26, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2