Removed code to handle GenerateUniqueName bug

[puppetsw]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes File not showing up after renaming from conflict dialog (via drag & drop) #9277

Details of Changes
Add details of changes here.

• Removed code that doesn't seem necessary anymore as dragging from zip respects the GenerateUniqueName enum. This also fixes the issue with dragging from a browser.

Validation
How did you test these changes?

• Built and ran the app

Screenshots (optional)
Add screenshots here.

[puppetsw]

@gave92 Did you want to have a look at this one? I believe you added the original code to handle the bug that was there. From my testing it seems no longer necessary?

[gave92]

Yep I'll check though I can't remember exactly what the problem was here. Like extracting the same file twice from .zip.

[gave92]

Ok I was able to reproduce the issue. Steps are:

• Open a .zip file in windows explorer
• Drag a file from the archive and drop it in a folder where an item with the same name already exists
• The existing file will get overwritten even if "generate new name" option was selected

Not sure what to do about that but sure I have to learn to write better comments -.-

[puppetsw]

Ok I was able to reproduce the issue. Steps are:

• Open a .zip file in windows explorer
• Drag a file from the archive and drop it in a folder where an item with the same name already exists
• The existing file will get overwritten even if "generate new name" option was selected

Not sure what to do about that but sure I have to learn to write better comments -.-

Ah yeah, the GenerateUniqueName is completely ignored.

I'll have another look and see if there is a possible workaround, but if you weren't able to find anything I don't think I will. If that's the case do you want me to just update the comment with this PR or close it out?

I wonder if it's because the File object from the dragged zip file doesn't contain a path, so it isn't able to compare correctly.

[puppetsw]

A bit of a hacky solution. What are your thoughts @gave92 ?

[gave92]

A bit of a hacky solution. What are your thoughts @gave92?

I don't like it 😜 but yeah it seems the only solution 👍

I wonder if it's because the File object from the dragged zip file doesn't contain a path, so it isn't able to compare correctly.

Path being empty appears not to be the only factor. When dragging files from Phone storage, path is also empty but GenerateUniqueName works fine.

[gave92]

@puppetsw do you mind if I tweak your solution slightly?

[puppetsw]

@puppetsw do you mind if I tweak your solution slightly?

Yeah go for it.

[gave92]

Done, I've made changes so:

• There's no risk of a "race condition", e.g. of a file appearing between the call to TryGetItemAsync and the actual copy
• Avoids using StorageFolder methods as they may not work if the destination folder is another zip file or some other special location
• Should be a little faster if there is no conflict

[puppetsw]

Looks much better now. I didn’t consider the race condition. Thanks for your help and input.