Skip to content

Allow to pin drives to favorites #9380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IgorKordiukiewicz
Copy link
Contributor

Resolved / Related Issues

Details of Changes
Drives can now be pinned/unpinned to/from favorites either through sidebar or home page.

I used already existing localized texts, so should I add new ones where needed or leave it as it is?

Validation

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Jun 9, 2022

@IgorKordiukiewicz can't you already pin drives to favorites?

@IgorKordiukiewicz
Copy link
Contributor Author

IgorKordiukiewicz commented Jun 9, 2022

The only way to do that now is by rightclicking on empty space in the disk's parent directory (but then if you rightclick the drive either in the sidebar or the drive's widget, there is no option to unpin it as compared to a folder).

Now:
rightclick_drive_before
After changes:
rightclick_drive_after

@yaira2
Copy link
Member

yaira2 commented Jun 10, 2022

I used already existing localized texts, so should I add new ones where needed or leave it as it is?

It's good as is, we prefer reusing strings wherever possible.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 15, 2022
@yaira2 yaira2 merged commit d1e3572 into files-community:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants