Skip to content

Refactor PreviewViewModel #9379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2022
Merged

Refactor PreviewViewModel #9379

merged 3 commits into from
Jun 23, 2022

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Jun 9, 2022 •
edited
Loading

Refactor preview view model

  • More readable code that uses new syntaxes
  • Avoids constantly re-instantiating the same objects.
  • Improves visibility (private/protected/public)
  • Remove unused code.

Also, I added new xml extensions (xsl, xslt, xlf, xsd)

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Jun 9, 2022

@cinqmilleans can you verify that you built and ran the app?

@cinqmilleans
Copy link
Contributor Author

ok

winston-de
winston-de approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@winston-de winston-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I learned a bunch of new C# syntax reviewing this :)

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 23, 2022
@yaira2 yaira2 merged commit 72620da into files-community:main Jun 23, 2022
@cinqmilleans
Copy link
Contributor Author

@winston-de Thank you a million times for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winston-de winston-de winston-de approved these changes

@Tina731114 Tina731114 Tina731114 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cinqmilleans @yaira2 @winston-de @Tina731114