Skip to content

Rotate multiple images #9150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2022
Merged

Conversation

puppetsw
Copy link
Contributor

@puppetsw puppetsw commented May 11, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Closes ...

Details of Changes
Add details of changes here.

  • Added ability to select multiple images and rotate left/right.
  • Added ability to select multiple images and set as desktop background (create slideshow) Currently only works on primary monitor.

Validation
How did you test these changes?

  • Built and ran the app

Demo
demo

@puppetsw puppetsw marked this pull request as ready for review May 12, 2022 13:57
@yaira2 yaira2 changed the title Rotate multiple images [Post 2.3] Rotate multiple images May 12, 2022
@yaira2 yaira2 marked this pull request as draft May 12, 2022 16:10
@puppetsw
Copy link
Contributor Author

@yaichenbaum would it be good to change the "set as background" text on the toolbar to "set as slideshow" when multiple images are selected?

@yaira2
Copy link
Member

yaira2 commented May 13, 2022

@yaichenbaum would it be good to change the "set as background" text on the toolbar to "set as slideshow" when multiple images are selected?

Either that or we can display a different button altogether.

@yaira2
Copy link
Member

yaira2 commented Jun 9, 2022

@puppetsw is this ready for review?

@puppetsw puppetsw marked this pull request as ready for review June 9, 2022 22:01
@yaira2
Copy link
Member

yaira2 commented Jun 9, 2022

What's the behavior if you have multiple file types selected in addition to the image?

@puppetsw
Copy link
Contributor Author

What's the behavior if you have multiple file types selected in addition to the image?

The button should remain hidden.

@yaira2 yaira2 changed the title [Post 2.3] Rotate multiple images Rotate multiple images Jun 10, 2022
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 13, 2022
@yaira2 yaira2 merged commit 70b73db into files-community:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants