Skip to content

Show Adaptive Layout as a separate layout in toolbar #9132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jun 9, 2022
Merged

Show Adaptive Layout as a separate layout in toolbar #9132

merged 23 commits into from
Jun 9, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented May 10, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added separate button on toolbar for Adaptive layout mode
  • Simplify layout-related code

Validation
How did you test these changes?

  • Built and ran the app

Screenshots (optional)
Add screenshots here.
image

@gave92 gave92 closed this May 10, 2022
@gave92 gave92 reopened this May 10, 2022
@gave92 gave92 changed the title Show Adaptive Layout as a separate layout in toolbar [Post 2.3] Show Adaptive Layout as a separate layout in toolbar May 10, 2022
@gave92
Copy link
Member Author

gave92 commented May 10, 2022 •
edited
Loading

@yaichenbaum is this something you'd include for v2.3?

@yaira2
Copy link
Member

yaira2 commented May 10, 2022

@yaichenbaum is this something you'd include for v2.3?

I would wait until after the release to merge this.

@gave92 gave92 marked this pull request as ready for review May 22, 2022 17:44
@yaira2
Copy link
Member

yaira2 commented Jun 9, 2022

It looks like switching to the column view prevents switching back to adaptive.

@yaira2 yaira2 self-requested a review June 9, 2022 18:47
@gave92
Copy link
Member Author

gave92 commented Jun 9, 2022

Yep, I have problems switching from columns to adaptive so I've disabled the button in that case. if you wish I can look more into it.

@yaira2
Copy link
Member

yaira2 commented Jun 9, 2022

Yep, I have problems switching from columns to adaptive so I've disabled the button in that case. if you wish I can look more into it.

It's up to you, personally I found it a bit confusing that I couldn't change the layout to adaptive.

@gave92
Copy link
Member Author

gave92 commented Jun 9, 2022 •
edited
Loading

Issue should be solved 💪. Uff code for changing layout mode is way too convoluted 😅

yaira2
yaira2 approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 9, 2022
@yaira2 yaira2 changed the title [Post 2.3] Show Adaptive Layout as a separate layout in toolbar Show Adaptive Layout as a separate layout in toolbar Jun 9, 2022
@yaira2 yaira2 merged commit f76bfee into files-community:main Jun 9, 2022
@gave92 gave92 deleted the default_layout branch June 10, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Adaptive Layout as a separate layout in toolbar
2 participants
@gave92 @yaira2