Skip to content

fix: file list randomly scrolling to top #9130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2022

Conversation

jiejasonliu
Copy link
Contributor

Resolved / Related Issues

Details of Changes
File list randomly scrolls to top on renaming and deleting* (especially if no confirmation dialog when deleting is on)
* deleting was fixed with (#8503), so couldn't reproduce on main

  • Select renamed files/folders (reuse code from selecting newly created items)
  • Deduplicate code for handling changes (anyEdits) in operation queue
  • Improve performance of finding selection item by only enumerating once

Validation

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Files-8159

@yaira2 yaira2 requested a review from gave92 May 10, 2022 14:11
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 12, 2022
Copy link
Member

@gave92 gave92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@gave92 gave92 self-requested a review May 12, 2022 19:56
@yaira2 yaira2 merged commit 1258999 into files-community:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After deleting or renaming files, file list scrolls to the top
3 participants