Implement folder setting to sort directories and files together and add option to toolbar sort flyout

[manfromarce]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Add option to sort flyout to sort files and folders together #7120.

Details of Changes

• The global setting to sort directories alongside files is removed and the option is loaded/saved per-folder (like "sort by" and ascending/descending)
• The option is added to the toolbar flyout

Validation
How did you test these changes?

• Built and ran the app

Screenshots (optional)

[manfromarce]

I've restored the global setting and it seems to work, except that already open tabs are not updated when the setting is changed.

[yaira2]

I've restored the global setting and it seems to work, except that already open tabs are not updated when the setting is changed.

Is this somethign you can copy from the option to show/hide hidden items?

[manfromarce]

The problem is that for each folder visited if there is no custom setting, the value of the global setting is saved. So when the user changes the global setting again it will have no effect on that folder

[yaira2]

The problem is that for each folder visited if there is no custom setting, the value of the global setting is saved. So when the user changes the global setting again it will have no effect on that folder

@manfromarce that's expected, to have the setting apply on all items you need to turn off the option to use individual preferences.

[manfromarce]

Ok, I've done some tests and the combination of global and individual settings seems to work properly

[yaira2]

Ok, I've done some tests and the combination of global and individual settings seems to work properly

Awesome! Do you think the option to set the default value should be disabled when the option to use individual preferences is turned off?

[gave92]

Ok, I've done some tests and the combination of global and individual settings seems to work properly

Awesome! Do you think the option to set the default value should be disabled when the option to use individual preferences is turned off?

Alternatives:

• the two options should synced <- preferred?
• the new option in the toolbar should be hidden

[manfromarce]

It could be that when individual settings are disabled the new toolbar command is synced with the general setting (like show hidden/dot files)

[yaira2]

It could be that when individual settings are disabled the new toolbar command is synced with the general setting (like show hidden/dot files)

That can work, we can change it later if it gets confusing.

[manfromarce]

@yaichenbaum @gave92 The settings should now be linked and refreshed correctly when individual settings are disabled, let me know what you think

[yaira2]

@manfromarce it's working great! We'll probably have to rearrange some options so that it's easier to see what's going on, but this is fantastic.
Do you want to add a setting to choose the default layout and default sort mode using the same logic?

[yaira2]

LGTM

[manfromarce]

OK, I think I can implement them. We could maybe add a new group in settings because "files and folders" would have too many entries

[yaira2]

OK, I think I can implement them. We could maybe add a new group in settings because "files and folders" would have too many entries

We can add a group for sorting preferences