Manually get folder name in case of network share folder or drive #9056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
May 15, 2022
d2dyno1
approved these changes
Jun 5, 2022
d2dyno1
reviewed
Jun 5, 2022
d2dyno1
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Details of Changes
Starting from .Net 5 as mentioned here,
GetFileNamedoes not get the Share folder name, but gets an empty string instead, which is how the bug arose.I added specific handling for UNC paths if it stops at the share level (ie : \127.0.0.1\share), and for Drive folders.
Validation
How did you test these changes?