Fixed grid view selection bugs #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsvietOK Can you review this pull request? |
|
@yaichenbaum Yeah |
|
@yaichenbaum From my side it is working fine. |
lukeblevins
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed selection bugs with the grid view layout (#660 and #678)
Removing the if statement in line 36
if (selectedItems.Count > 0)fixes the deselect and then reselect bugs.
I have read the commented warning above the if, but I haven't been able to recreate any crashes or issues by removing it.
Line 200
(sender as UIElement).CanDrag = FileList.SelectedItems.Contains(sender.DataContext as ListedItem);fixes the issue whereby browsing up or down into a folder prevents the user from being able to select files.
Here's the result:
