Skip to content

Fixed file rename with space added opening QuickLook #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

Fixed file rename with space added opening QuickLook #780

merged 1 commit into from
May 13, 2020

Conversation

Dylan-Osborne
Copy link
Contributor

Fixed a bug that caused QuickLook to open when pressing spacebar while renaming a file.

Before:
before
After:
after

To Reproduce In Current Version
Steps to reproduce the behavior:

  1. Make sure you have QuickLook installed.
  2. Right click on a file and choose "Rename"
  3. Give the file any name with a space in it. As soon as spacebar is pressed, QuickLook opens, the file name textbox loses focus and the file name is committed without allowing the user to finish typing.

@ghost ghost added the needs - code review label May 13, 2020
@yaira2 yaira2 self-requested a review May 13, 2020 12:41
yaira2
yaira2 reviewed May 13, 2020
View reviewed changes
@lukeblevins lukeblevins self-requested a review May 13, 2020 21:49
@lukeblevins lukeblevins added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 13, 2020
@yaira2 yaira2 merged commit f3e6cb3 into files-community:develop May 13, 2020
@yaira2
Copy link
Member

yaira2 commented May 13, 2020

@Dylan-Osborne Thank you for your pull request, I just merged it into the develop branch. Your changes should make their way into the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

@lukeblevins lukeblevins lukeblevins approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dylan-Osborne @yaira2 @lukeblevins