Add global.json to force sdk 6.0.100 #7656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
approved these changes
Jan 14, 2022
|
@gave92 the store recompiles the app on their servers, will this help for that? |
|
I'm hoping it does, I have no experience with the Store. Is it possible to test Store version before publishing it to everyone? |
|
@gave92 I'll test it out and if it doesn't work, we can revert the change. |
yaira2
added a commit
that referenced
this pull request
Jan 16, 2022
|
Store pipeline is getting the wrong sdk version in "UseDotNet" step. Sideload release was perfectly fine. |
|
@yaichenbaum what .yml configuration file is used for store release? You need to do the same change that was done in #7422 |
|
@gave92 it's the release pipeline so it was already done 🤔 |
|
Gah found it |
Ha! It was changed but only for the sideload release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Details of Changes
Add details of changes here.
This change should force the Store to build the app using sdk 6.0.100 like CI does. This apparently is mandatory or fulltrust process will crash (at least on windows 10).
NOTE: adding this file to the repo will cause building the app to fail unless the exact version of the sdk is installed. This is annoying for contributors, if possible I'd only use it when submitting a new version to the Store.