Skip to content

Added more Arabic translation #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 16, 2022
Merged

Added more Arabic translation #7653

merged 9 commits into from
Jan 16, 2022

Conversation

0x61nas
Copy link
Contributor

@0x61nas 0x61nas commented Jan 14, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added more Arabic translations
  • Fixed some Arabic translations

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@0x61nas
Copy link
Contributor Author

0x61nas commented Jan 14, 2022

I am still working on translating more strings, but I made a withdrawal request in order to facilitate the process of reviewing changes before they become too big and difficult to review.

@0x61nas 0x61nas changed the title Add more Arabic translation Added more Arabic translation Jan 14, 2022
@yaira2
Copy link
Member

yaira2 commented Jan 14, 2022

@anas-elgarhy before we merge this, can you add your agreement to #7625?

@0x61nas
Copy link
Contributor Author

0x61nas commented Jan 14, 2022

@yaichenbaum I've already added it

#7625 (comment)

@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Jan 14, 2022
@0x61nas 0x61nas requested a review from yaira2 January 14, 2022 22:37
@yaira2 yaira2 removed the changes requested Changes are needed for this pull request label Jan 16, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 16, 2022
@yaira2 yaira2 merged commit 383f953 into files-community:main Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This sentences has not been translated into Arabic
2 participants