-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix mistranslations in Files.ja-JP.xlf
.
#7649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@h1g0 Im a Japanese. do you think of wide-chars(such as "!" or "?")? Translation rules
Issue translations Below, GitHub is usually recommended to write in English, but I will write it in Japanese(avoiding misunderstand).
What do you think based on the above? If you agree this, I will open a PR about this and providing missing ja-jp resources of xlf and resx. |
@onein528 In addition, what about the long vowel symbol So I have the following thoughts on your translation rules (I also write in Japanese):
|
Yes, I agree all of this.
I think too. Create another issue. |
Resolved / Related Issues
Items resolved / related issues by this PR.
Details of Changes
Add details of changes here.
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.