Skip to content

Fix text selection when renaming #7455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jan 5, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Do not focus filelist on pointer up when renaming

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested a review from yaira2 January 5, 2022 13:31
@yaira2
Copy link
Member

yaira2 commented Jan 5, 2022

@gave92 it looks like clicking outside the listview doesn't cancel the rename anymore.

@gave92
Copy link
Member Author

gave92 commented Jan 5, 2022

Any better now?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 5, 2022
@yaira2 yaira2 merged commit 05a9894 into files-community:main Jan 5, 2022
@gave92 gave92 deleted the issue_7449 branch January 5, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting text in the rename box cancels the rename action in all layout modes
2 participants