Skip to content

Improve keyboard navigation in column view #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jan 5, 2022
Merged

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jan 3, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Use left/right arrow keys to navigate column view
  • Autofocus file list on navigation (all view modes)
  • Ability to select first item by keyboard when a folder contains only one item (all view modes)
  • Open selected folder in a new column when pressing Enter
  • Remove redundant resources from ColumnViewBrowser
  • Partially fix back/forward buttons for ColumnView
  • Switch active column or pane when using Tab key
  • Scroll focused column into view

To be merged after #7390

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 marked this pull request as ready for review January 4, 2022 09:13
@yaira2 yaira2 self-requested a review January 4, 2022 15:09
@yaira2
Copy link
Member

yaira2 commented Jan 4, 2022

@gave92 is #5375 supposed to default to opening folders in one click in the column view or should that be a separate option in the settings dialog to implement in a different PR?

yaira2
yaira2 previously approved these changes Jan 4, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 4, 2022
@yaira2 yaira2 merged commit dcd056e into files-community:main Jan 5, 2022
@gave92 gave92 deleted the focus3 branch January 5, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
2 participants