Skip to content

Install fonts through powershell #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2022
Merged

Install fonts through powershell #7394

merged 1 commit into from
Jan 2, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 31, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Given that "Install" and "Install for all users" don't correctly install fonts, "manually" install fonts through powershell instead

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 requested a review from BanCrash December 31, 2021 16:54
BanCrash
BanCrash approved these changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fun fact, with the previous version installing for just my user was working but they can't be uninstalled lol. With this commit those can be removed as expected.

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 2, 2022
@gave92
Copy link
Member Author

gave92 commented Jan 2, 2022 •
edited
Loading

@BanCrash yeah the font was copied to the fonts folder but it was not added to the registry (so uninstall didn't work)

@yaira2 yaira2 merged commit 487fbcf into files-community:main Jan 2, 2022
@yaira2 yaira2 mentioned this pull request Jan 2, 2022
Closed
@gave92 gave92 deleted the install_fonts branch January 2, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BanCrash BanCrash BanCrash approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fonts not installed correctly using shell context menu
3 participants
@gave92 @BanCrash @yaira2