Skip to content

Extended click area to whole settings' block #7336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2021
Merged

Extended click area to whole settings' block #7336

merged 2 commits into from
Dec 21, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Dec 20, 2021 •
edited by yaira2
Loading

Resolved / Related Issues

Details of Changes

  • The click area of actionable settings' blocks has been extended

Validation

  • Built and ran the app
  • Tested the changes for accessibility

@d2dyno1 d2dyno1 requested a review from yaira2 December 20, 2021 21:13
yaira2
yaira2 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 21, 2021
@yaira2 yaira2 merged commit a84fab4 into files-community:main Dec 21, 2021
@yaira2 yaira2 mentioned this pull request Dec 21, 2021
Closed
@d2dyno1 d2dyno1 deleted the f_stngs_bar_clkopn branch December 21, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change sections with links in settings dialog to function as regular buttons
2 participants
@d2dyno1 @yaira2