Skip to content

Update tab titles using current navigation arguments #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jiejasonliu
Copy link
Contributor

Hey there! This is my first PR so let me know of any improvements I can make! Thanks for the patience! 😄

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes

  • Use current navigation args instead of previously stored selection in left pane when possible

Validation
How did you test these changes?

  • Built and ran the app

Screenshots (optional)
Files-7331

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 21, 2021
@yaira2
Copy link
Member

yaira2 commented Dec 21, 2021

@jiejasonliu great work, thank you for contributing to Files 🙂

@yaira2 yaira2 merged commit 531fcc6 into files-community:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab titles don't update when using the "columns" layout
3 participants