Skip to content

Removed duplicate strings #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Files/Dialogs/AddItemDialog.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public async void AddItemsToList()

AddItemsList.Add(new AddListItem
{
Header = "AddDialogListFolderHeader".GetLocalized(),
Header = "Folder".GetLocalized(),
SubHeader = "AddDialogListFolderSubHeader".GetLocalized(),
Glyph = "\xE838",
IsItemEnabled = true,
Expand Down
3 changes: 1 addition & 2 deletions src/Files/Dialogs/DecompressArchiveDialog.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@
Text="{x:Bind ViewModel.DestinationFolderPath, Mode=OneWay}" />

<Button
x:Uid="DecompressArchiveDialogBrowseFolder"
Grid.Column="1"
VerticalAlignment="Center"
Background="Transparent"
Command="{x:Bind ViewModel.SelectDestinationCommand}"
Content="Browse" />
Content="{helpers:ResourceString Name=Browse}" />

<CheckBox
x:Uid="DecompressArchiveDialogOpenDestinationWhenComplete"
Expand Down
2 changes: 1 addition & 1 deletion src/Files/Dialogs/ElevateConfirmDialog.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
x:Name="ConfirmElevationDialog"
x:Uid="ElevateConfirmDialog"
Title="This action requires adminstrator rights"
CloseButtonText="No"
CloseButtonText="{local2:ResourceString Name=No}"
Content="Would you like to continue as administrator?"
CornerRadius="{StaticResource OverlayCornerRadius}"
DefaultButton="None"
Expand Down
6 changes: 2 additions & 4 deletions src/Files/Dialogs/FilesystemOperationDialog.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,9 @@
Tag="1"
Text="Replace existing" />
<MenuFlyoutItem
x:Uid="ConflictingItemsDialogOptionSkip"
Click="MenuFlyoutItem_Click"
Tag="2"
Text="Skip" />
Text="{helpers:ResourceString Name=Skip}" />
<MenuFlyoutSeparator x:Name="ApplyToAllSeparator" />
<MenuFlyoutItem
x:Name="ApplyToAllOption"
Expand Down Expand Up @@ -215,9 +214,8 @@
Command="{Binding ReplaceExistingCommand}"
Text="Replace" />
<MenuFlyoutItem
x:Uid="ConflictingItemsDialogItemOptionSkip"
Command="{Binding SkipCommand}"
Text="Skip" />
Text="{helpers:ResourceString Name=Skip}" />
</MenuFlyout>
</muxc:SplitButton.Flyout>
</muxc:SplitButton>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ await DialogDisplayHelper.ShowDialogAsync(
{
Title = "ErrorDialogThisActionCannotBeDone".GetLocalized(),
Content = $"{"ErrorDialogTheDestinationFolder".GetLocalized()} ({destinationName}) {"ErrorDialogIsASubfolder".GetLocalized()} (sourceName)",
//PrimaryButtonText = "ErrorDialogSkip".GetLocalized(),
//PrimaryButtonText = "Skip".GetLocalized(),
CloseButtonText = "Cancel".GetLocalized()
};

Expand Down Expand Up @@ -426,7 +426,7 @@ await DialogDisplayHelper.ShowDialogAsync(
{
Title = "ErrorDialogThisActionCannotBeDone".GetLocalized(),
Content = "ErrorDialogTheDestinationFolder".GetLocalized() + " (" + destinationName + ") " + "ErrorDialogIsASubfolder".GetLocalized() + " (" + sourceName + ")",
//PrimaryButtonText = "ErrorDialogSkip".GetLocalized(),
//PrimaryButtonText = "Skip".GetLocalized(),
CloseButtonText = "Cancel".GetLocalized()
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@ public async Task<ReturnResult> RenameAsync(IStorageItemWithPath source, string
not when file name has changed */
if (Path.GetExtension(source.Path) != Path.GetExtension(newName))
{
var yesSelected = await DialogDisplayHelper.ShowDialogAsync("RenameFileDialogTitle".GetLocalized(), "RenameFileDialog/Text".GetLocalized(), "ButtonYes/Content".GetLocalized(), "ButtonNo/Content".GetLocalized());
var yesSelected = await DialogDisplayHelper.ShowDialogAsync("RenameFileDialogTitle".GetLocalized(), "RenameFileDialog/Text".GetLocalized(), "Yes".GetLocalized(), "No".GetLocalized());
if (yesSelected)
{
history = await filesystemOperations.RenameAsync(source, newName, collision, errorCode, cancellationToken);
Expand Down
2 changes: 1 addition & 1 deletion src/Files/Filesystem/ListedItem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ public override string ToString()
}
else
{
suffix = PrimaryItemAttribute == StorageItemTypes.File ? "FileItemAutomation".GetLocalized() : "FolderItemAutomation".GetLocalized();
suffix = PrimaryItemAttribute == StorageItemTypes.File ? "Folder".GetLocalized() : "FolderItemAutomation".GetLocalized();
}

return $"{ItemName}, {suffix}";
Expand Down
8 changes: 4 additions & 4 deletions src/Files/Filesystem/Permissions/FileSystemAccessRuleForUI.cs
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public FileSystemRights FileSystemRights
_ => "\xF140"
};

public string IsInheritedForUI => IsInherited ? "Yes".GetLocalized() : "SecurityAdvancedInheritedNoLabel".GetLocalized();
public string IsInheritedForUI => IsInherited ? "Yes".GetLocalized() : "No".GetLocalized();

public string FileSystemRightsForUI => string.Join(", ", GetPermissionStrings());

Expand Down Expand Up @@ -332,7 +332,7 @@ private List<GrantedPermission> GetGrantedPermissions()
gpl.Add(new GrantedPermission(this)
{
Permission = FileSystemRights.Write,
Name = "SecurityWriteLabel/Text".GetLocalized(),
Name = "Write".GetLocalized(),
IsEditable = !IsInherited
});
gpl.Add(new SpecialPermission(this)
Expand Down Expand Up @@ -392,7 +392,7 @@ private IList<string> GetPermissionStrings()
var ret = new List<string>();
if (FileSystemRights == 0)
{
ret.Add("SecurityNoneLabel/Text".GetLocalized());
ret.Add("None".GetLocalized());
}
if (GrantsFullControl)
{
Expand All @@ -412,7 +412,7 @@ private IList<string> GetPermissionStrings()
}
if (!GrantsFullControl && !GrantsModify && GrantsWrite)
{
ret.Add("SecurityWriteLabel/Text".GetLocalized());
ret.Add("Write".GetLocalized());
}
if (GrantsSpecial)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Files/Helpers/AcrylicTheme.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public AcrylicTheme()
FallbackColor = (Color)App.Current.Resources["SolidBackgroundFillColorBase"];
}

public void SetDefaultTheme()
public void SetDefault()
{
if (Application.Current.RequestedTheme == ApplicationTheme.Light)
{
Expand Down
26 changes: 13 additions & 13 deletions src/Files/Helpers/ContextFlyoutItemHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
// Details view
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutDetails/Text".GetLocalized(),
Text = "Details".GetLocalized(),
Glyph = "\uE179",
ShowInRecycleBin = true,
ShowInSearchPage = true,
Expand Down Expand Up @@ -182,7 +182,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
// Column view
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutColumn/Text".GetLocalized(),
Text = "Columns".GetLocalized(),
Glyph = "\uF115",
GlyphFontFamilyName = "CustomGlyph",
ShowInRecycleBin = true,
Expand Down Expand Up @@ -234,7 +234,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutSortByDateCreated/Text".GetLocalized(),
Text = "DateCreated".GetLocalized(),
IsChecked = itemViewModel.IsSortedByDateCreated,
Command = new RelayCommand(() => itemViewModel.IsSortedByDateCreated = true),
ShowInRecycleBin = true,
Expand All @@ -256,7 +256,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutSortBySize/Text".GetLocalized(),
Text = "Size".GetLocalized(),
IsChecked = itemViewModel.IsSortedBySize,
Command = new RelayCommand(() => itemViewModel.IsSortedBySize = true),
ShowInRecycleBin = true,
Expand Down Expand Up @@ -294,7 +294,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutSortByDateDeleted/Text".GetLocalized(),
Text = "DateDeleted".GetLocalized(),
IsChecked = itemViewModel.IsSortedByDateDeleted,
Command = new RelayCommand(() => itemViewModel.IsSortedByDateDeleted = true),
ShowInRecycleBin = true,
Expand All @@ -311,7 +311,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutSortByAscending/Text".GetLocalized(),
Text = "Ascending".GetLocalized(),
IsChecked = itemViewModel.IsSortedAscending,
Command = new RelayCommand(() => itemViewModel.IsSortedAscending = true),
ShowInRecycleBin = true,
Expand Down Expand Up @@ -345,7 +345,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
{
new ContextMenuFlyoutItemViewModel()
{
Text = "NavToolbarGroupByOptionNone/Text".GetLocalized(),
Text = "None".GetLocalized(),
IsChecked = currentInstanceViewModel.FolderSettings.DirectoryGroupOption == GroupOption.None,
ShowInRecycleBin = true,
ShowInSearchPage = true,
Expand Down Expand Up @@ -381,7 +381,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutSortByDateCreated/Text".GetLocalized(),
Text = "DateCreated".GetLocalized(),
IsChecked = currentInstanceViewModel.FolderSettings.DirectoryGroupOption == GroupOption.DateCreated,
ShowInRecycleBin = true,
ShowInSearchPage = true,
Expand All @@ -405,7 +405,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutSortBySize/Text".GetLocalized(),
Text = "Size".GetLocalized(),
IsChecked = currentInstanceViewModel.FolderSettings.DirectoryGroupOption == GroupOption.Size,
ShowInRecycleBin = true,
ShowInSearchPage = true,
Expand Down Expand Up @@ -447,7 +447,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutSortByDateDeleted/Text".GetLocalized(),
Text = "DateDeleted".GetLocalized(),
IsChecked = currentInstanceViewModel.FolderSettings.DirectoryGroupOption == GroupOption.DateDeleted,
ShowInRecycleBin = true,
Command = currentInstanceViewModel.FolderSettings.ChangeGroupOptionCommand,
Expand Down Expand Up @@ -503,7 +503,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseLayoutMenuItems(Curren
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutOpenInTerminal/Text".GetLocalized(),
Text = "OpenInTerminal".GetLocalized(),
Glyph = "\uE756",
Command = commandsViewModel.OpenDirectoryInDefaultTerminalCommand,
},
Expand Down Expand Up @@ -766,7 +766,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(BaseLayo
},
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutItemContextFlyoutCopy/Text".GetLocalized(),
Text = "Copy".GetLocalized(),
//Glyph = "\uF8C8",
ColoredIcon = new ColoredIconModel()
{
Expand Down Expand Up @@ -1023,7 +1023,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetNewItemItems(BaseLayoutCom
{
new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutContextFlyoutNewFolder/Text".GetLocalized(),
Text = "Folder".GetLocalized(),
Glyph = "\uE8B7",
Command = commandsViewModel.CreateNewFolderCommand,
ShowInFtpPage = true,
Expand Down
2 changes: 1 addition & 1 deletion src/Files/Helpers/ExternalResourcesHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class ExternalResourcesHelper
{
new AppTheme
{
Name = "DefaultTheme".GetLocalized(),
Name = "Default".GetLocalized(),
},
};

Expand Down
2 changes: 1 addition & 1 deletion src/Files/Helpers/ItemListDisplayHelpers/GroupingHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public static (Action<GroupedCollection<ListedItem>>, Action<GroupedCollection<L
{
ListedItem first = x.First();
x.Model.ShowCountTextBelow = true;
x.Model.Text = first.FileTagUI?.TagName ?? "NavToolbarGroupByOptionNone/Text".GetLocalized();
x.Model.Text = first.FileTagUI?.TagName ?? "None".GetLocalized();
//x.Model.Icon = first?.FileTagUI?.Color;
}, null),

Expand Down
2 changes: 1 addition & 1 deletion src/Files/Helpers/ThemeHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ private static void ApplyTheme()
switch (rootTheme)
{
case ElementTheme.Default:
App.AppSettings.AcrylicTheme.SetDefaultTheme();
App.AppSettings.AcrylicTheme.SetDefault();
titleBar.ButtonHoverBackgroundColor = (Color)Application.Current.Resources["SystemBaseLowColor"];
titleBar.ButtonForegroundColor = (Color)Application.Current.Resources["SystemBaseHighColor"];
break;
Expand Down
Loading