Skip to content

Added support for collapsing widgets on the homepage #7285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 15, 2021
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Dec 13, 2021

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Known issues
Additional options flyout overlaps with content. The solution is to move the flyout to the expander header. Support should also be added to keep track of the expanded state.

Screenshots (optional)
image

@yaira2 yaira2 marked this pull request as draft December 13, 2021 21:33
@yaira2 yaira2 marked this pull request as ready for review December 13, 2021 23:57
@yaira2 yaira2 requested a review from d2dyno1 December 13, 2021 23:57
@d2dyno1
Copy link
Member

d2dyno1 commented Dec 15, 2021

@yaichenbaum The state of expanders is not preserved between instances and on app restart

@yaira2
Copy link
Member Author

yaira2 commented Dec 15, 2021

@yaichenbaum The state of expanders is not preserved between instances and on app restart

Tracking that in #7286

@d2dyno1
Copy link
Member

d2dyno1 commented Dec 15, 2021

@yaichenbaum The state of expanders is not preserved between instances and on app restart

Tracking that in #7286

Nah, if you'd like to I could implement it and push it to this branch so #7286 is closed with this one.

@yaira2
Copy link
Member Author

yaira2 commented Dec 15, 2021

@yaichenbaum The state of expanders is not preserved between instances and on app restart

Tracking that in #7286

Nah, if you'd like to I could implement it and push it to this branch so #7286 is closed with this one.

Go ahead 👍

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 15, 2021
@yaira2 yaira2 merged commit 75f7383 into main Dec 15, 2021
@yaira2 yaira2 deleted the WidgetExpanders branch December 15, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants