Fixed app crash #728
Merged
Fixed app crash #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Var TintLuminosityOpacity removed as it has the same value(0.9) for light and dark themes. Renamed class
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for this PR. Could you please explain how this one fixes the crash? |
|
@duke7553 Read my comment here |
lukeblevins
approved these changes
May 4, 2020
|
@duke7553 May be you can realize possible reasons why setting a value to var causes app crash in release mode |
yaira2
added
ready to merge
BuraChuhadar
pushed a commit
to BuraChuhadar/files-uwp
that referenced
this pull request
May 18, 2020
Var TintLuminosityOpacity removed as it has the same value(0.9) for light and dark themes. Renamed class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Var TintLuminosityOpacity removed as it has the same value(0.9) for light and dark themes.
Renamed class
Fixes #720