Added experimental option to show folder sizes #7244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Dec 8, 2021
yaira2
reviewed
Dec 8, 2021
yaira2
reviewed
Dec 8, 2021
|
@cinqmilleans I found an issue that if you select a folder when the size is still calculating, the size in the status bar doesn't get updated. |
|
@yaichenbaum Indeed. I take care of it. |
|
@yaichenbaum I was able to correct the problem. However I notice that the cumulative size is not displayed when there are folders in the multiselection. I will try to add this functionality. |
|
@yaichenbaum The size is now displayed for a selection containing folders. |
yaira2
added
ready to merge
yaira2
changed the title
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
It is not practical to know the total size occupied by a folder. You have to select one, open its property panel, and wait for the calculation. It is therefore not easy to spot a folder whose size is larger than desired. Closes #3944 #6880.
Details of Changes
Add experimental setting for show folder size. The size is calculated asynchronously with no visible loss in performance. The size is visible in details view and status bar.
Works for local folders & library & OneDrive.
Should work on other clouds and ftp but I haven't tested because I don't have one.
Does not work inside a zip file. It can come later.
Validation
How did you test these changes?