Skip to content

Update German Translation #7228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Update German Translation #7228

merged 2 commits into from
Dec 6, 2021

Conversation

heckelson
Copy link
Contributor

Resolved / Related Issues

none

Details of Changes

I reviewed the German translation file (Files/MultilingualResources/Files.de-DE.xlf).

  • looked for all occurences of state="needs-review-translation" in the file and reviewed them, editing if necessary
  • deleted all <note> entries, when no longer relevant
  • Added translations to all occurences of state="new"

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@d2dyno1
Copy link
Member

d2dyno1 commented Dec 6, 2021

@R3voA3 fyi

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Dec 6, 2021
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Dec 6, 2021
@yaira2 yaira2 merged commit e9acf2c into files-community:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants