Skip to content

Fix properties window not closing on OK #7201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 3, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Set symlink target path in Properties as readonly and hide arguments, working directory
  • Fixes an issue where Properties window does not close if Shortcut section is expanded
  • Fixes #3524514594u (crash if fulltrust process fails to fetch Compatibility properties)

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested a review from BanCrash December 3, 2021 01:31
@gave92 gave92 marked this pull request as draft December 3, 2021 01:36
@gave92 gave92 marked this pull request as ready for review December 3, 2021 01:53
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

An issue for a future PR (I'll open an issue about this):
When you edit the info of a shortcut, you'll need to refresh the folder to get the updated shortcut information (the icon is updated though):

GIF 06-12-2021 16-06-10

On the gif I've tried two times before refreshing to make sure that it's not a question about opening one time after editing it to get the refreshed info.

I opened the Eclipse lua shortcut and edited its info with the GifCam info, and I needed to refresh the folder to have the new shortcut information.

EDIT: I've forgot to capture the mouse , I can add a new gif if it's not very clear what the issue is.

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 6, 2021
@yaira2 yaira2 merged commit ad97931 into files-community:main Dec 6, 2021
@gave92 gave92 deleted the fixes_properties branch December 6, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential race condition in FileOperationsHandler
3 participants