Skip to content

Improve taskbar jumplist #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 5, 2022
Merged

Improve taskbar jumplist #7141

merged 12 commits into from
Jan 5, 2022

Conversation

jaigak
Copy link
Contributor

@jaigak jaigak commented Nov 29, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • The most recent item will now be shown on the top of the taskbar jumplist.
  • Fixed an issue where the root of a drive won't be added on the taskbar jumplist.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

yaira2
yaira2 reviewed Nov 29, 2021
View reviewed changes
yaira2
yaira2 reviewed Nov 29, 2021
View reviewed changes
@jaigak @yaira2
Update Files/App.xaml.cs
38f8968 
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@yaira2 yaira2 requested a review from d2dyno1 November 29, 2021 14:45
@jaigak jaigak requested a review from yaira2 November 29, 2021 15:47
lukeblevins
lukeblevins reviewed Nov 29, 2021
View reviewed changes
@jaigak @lukeblevins
Update Files/ViewModels/MainPageViewModel.cs
cc24d3d 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@jaigak jaigak requested a review from lukeblevins November 30, 2021 03:36
@d2dyno1 d2dyno1 removed their request for review November 30, 2021 18:05
@yaira2 yaira2 requested a review from gave92 November 30, 2021 19:32
gave92
gave92 reviewed Dec 2, 2021
View reviewed changes
Copy link
Member

@gave92 gave92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍. See a couple of comments.

@jaigak jaigak requested a review from gave92 December 2, 2021 03:05
@jaigak jaigak changed the title Support listing recently accessed drives on the taskbar jumplist Improve taskbar jumplist Dec 2, 2021
gave92
gave92 suggested changes Dec 2, 2021
View reviewed changes
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Dec 5, 2021
@d2dyno1
Copy link
Member

d2dyno1 commented Dec 21, 2021

@Jaiganeshkumaran

@jaigak jaigak requested a review from gave92 December 23, 2021 02:14
@yaira2 yaira2 removed their request for review December 23, 2021 03:18
yaira2
yaira2 requested changes Dec 23, 2021
View reviewed changes
yaira2
yaira2 previously approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Jan 4, 2022
gave92
gave92 previously approved these changes Jan 4, 2022
View reviewed changes
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 4, 2022
@yaira2
Copy link
Member

yaira2 commented Jan 4, 2022

@Jaiganeshkumaran can you resolve the merge conflicts?

@jaigak jaigak dismissed stale reviews from gave92 and yaira2 via 3d16e61 January 5, 2022 11:49
@jaigak jaigak requested review from gave92 and yaira2 January 5, 2022 11:49
@yaira2
Copy link
Member

yaira2 commented Jan 5, 2022

@Jaiganeshkumaran thank you!

@yaira2 yaira2 merged commit fb209b0 into files-community:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 approved these changes

@lukeblevins lukeblevins Awaiting requested review from lukeblevins

@yaira2 yaira2 Awaiting requested review from yaira2

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Add drives to the taskbar jumplist
5 participants
@jaigak @d2dyno1 @yaira2 @gave92 @lukeblevins