Skip to content

Mousewheel click opens new tab at selected path #7126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Raithlin
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added method to capture mouse clicks. Middle clicks are filtered and a new tab opened.

Validation
How did you test these changes?

  • [X ] Built and ran the app
  • [X ] Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title #3667 mousewheel click opens new tab at selected path Mousewheel click opens new tab at selected path Nov 28, 2021
…licate file across different folder names"

This reverts commit e2dd7f4.
@yaira2 yaira2 requested a review from BanCrash November 29, 2021 14:19
@yaira2 yaira2 self-requested a review November 29, 2021 14:19
yaira2
yaira2 previously approved these changes Nov 30, 2021
@BanCrash
Copy link
Contributor

BanCrash commented Dec 2, 2021

@Raithlin do you know why sometimes it opens the same folder in both new tab and actual tab? I can't replicate consistently, but it happens some times in my tests without any apparently reason.

GIF 02-12-2021 14-41-20

@Raithlin
Copy link
Contributor Author

Raithlin commented Dec 2, 2021

I had that happen once, thought I had clicked on something else. I can take a look - most likely the click method is being called as well. I can't check the mouse status in that method either, so it makes it a little more difficult to prevent. Any ideas?

@Raithlin
Copy link
Contributor Author

Raithlin commented Dec 2, 2021

I added logging (temporarily) to see which methods were being called. Both were.
I changed the process to use a private pointerroutereventargs to pass to the tapped event as per https://stackoverflow.com/questions/44111224/pointerpressed-vs-tapped#44125921. No click through happening any more, and the middle click still works.

@Raithlin Raithlin requested a review from yaira2 December 3, 2021 14:56
Co-authored-by: BanCrash <BanCrash@users.noreply.github.com>
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 6, 2021
@yaira2 yaira2 merged commit 592d7a7 into files-community:main Dec 6, 2021
@Raithlin Raithlin deleted the #3667-Mousewheel-opens-new-tab branch December 7, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click with Wheel on Subpath on PathBar -> Open in new Tab
3 participants