Skip to content

Fixed invalid items from being added to bundles #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2021
Merged

Fixed invalid items from being added to bundles #7119

merged 5 commits into from
Nov 28, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Nov 28, 2021

Resolved / Related Issues

Details of Changes

  • This PR replaces the old ToStorageItem() function with a newer and faster one from Clipboard Canvas.

Validation
How did you test these changes?

  • Built and ran the app

@d2dyno1 d2dyno1 requested a review from gave92 November 28, 2021 14:51
gave92
gave92 reviewed Nov 28, 2021
View reviewed changes
gave92
gave92 reviewed Nov 28, 2021
View reviewed changes
gave92
gave92 reviewed Nov 28, 2021
View reviewed changes
gave92
gave92 reviewed Nov 28, 2021
View reviewed changes
gave92
gave92 reviewed Nov 28, 2021
View reviewed changes
@d2dyno1 d2dyno1 requested a review from gave92 November 28, 2021 16:04
gave92
gave92 reviewed Nov 28, 2021
View reviewed changes
@d2dyno1 d2dyno1 requested a review from gave92 November 28, 2021 16:21
gave92
gave92 approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@gave92 gave92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 28, 2021
yaira2
yaira2 approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix invalid folders loaded in bundles Fixed invalid items from being added to bundles Nov 28, 2021
@yaira2 yaira2 merged commit 8185655 into files-community:main Nov 28, 2021
@yaira2 yaira2 mentioned this pull request Nov 28, 2021
Closed
@d2dyno1 d2dyno1 deleted the fix_bndls_itms branch November 28, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open a directory which name include "." from Bundles Widget
3 participants
@d2dyno1 @gave92 @yaira2