Skip to content

Added clear all button #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 27, 2021
Merged

Added clear all button #7025

merged 9 commits into from
Nov 27, 2021

Conversation

petrjancar
Copy link
Contributor

@petrjancar petrjancar commented Nov 22, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added button "Dismiss all" to clear all inactive tasks in one click.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Nov 22, 2021

@petrjancar can you upload a screenshot of the changes?

Only finished tasks are removed now.
@petrjancar
Copy link
Contributor Author

@yaichenbaum
Screenshot 2021-11-23 000356

@yaira2
Copy link
Member

yaira2 commented Nov 22, 2021

@petrjancar very nice! Does it cancel ongoing operations as well?

@petrjancar
Copy link
Contributor Author

@petrjancar very nice! Does it cancel ongoing operations as well?

No, it only clears all inactive tasks, as requested.

@yaira2
Copy link
Member

yaira2 commented Nov 23, 2021

@petrjancar that might be confusing if there are other ongoing operations, do you have any thoughts on how to improve the UX?

@d2dyno1
Copy link
Member

d2dyno1 commented Nov 25, 2021

"Dismiss completed"?

@petrjancar
Copy link
Contributor Author

"Dismiss completed"?

Sounds good to me. What do you think @yaichenbaum?

@yaira2
Copy link
Member

yaira2 commented Nov 26, 2021

@petrjancar looking at the draft of the design spec, it looks like there are plans to have a separate section on the bottom for completed tasks at the bottom of the flyout so it turns out that "clear all" should work.
image

@petrjancar
Copy link
Contributor Author

@petrjancar looking at the draft of the design spec, it looks like there are plans to have a separate section on the bottom for completed tasks at the bottom of the flyout so it turns out that "clear all" should work. image

Ok, I updated string in en-us .resw file to "Clear all" instead of "Dismiss all".

@yaira2
Copy link
Member

yaira2 commented Nov 26, 2021

@petrjancar in another PR, do you want to create a new section to seperate ongoing and completed tasks?

Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@petrjancar
Copy link
Contributor Author

@petrjancar in another PR, do you want to create a new section to seperate ongoing and completed tasks?

Thanks but not now, I am currently working on other PR.

@yaira2 yaira2 requested a review from d2dyno1 November 27, 2021 23:17
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 27, 2021
@yaira2
Copy link
Member

yaira2 commented Nov 27, 2021

@petrjancar thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add clear all button in the Ongoing tasks flyout
3 participants