-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Added clear all button #7025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clear all button #7025
Conversation
@petrjancar can you upload a screenshot of the changes? |
Only finished tasks are removed now.
Typo fixed.
@petrjancar very nice! Does it cancel ongoing operations as well? |
Added ClearAll string.
Updated Dismiss All button.
No, it only clears all inactive tasks, as requested. |
@petrjancar that might be confusing if there are other ongoing operations, do you have any thoughts on how to improve the UX? |
"Dismiss completed"? |
Sounds good to me. What do you think @yaichenbaum? |
@petrjancar looking at the draft of the design spec, it looks like there are plans to have a separate section on the bottom for completed tasks at the bottom of the flyout so it turns out that "clear all" should work. |
Ok, I updated string in en-us .resw file to "Clear all" instead of "Dismiss all". |
@petrjancar in another PR, do you want to create a new section to seperate ongoing and completed tasks? |
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Thanks but not now, I am currently working on other PR. |
@petrjancar thank you! |
Resolved / Related Issues
Items resolved / related issues by this PR.
Details of Changes
Add details of changes here.
Validation
How did you test these changes?