Skip to content

Fixed an issue where the option to reset the default file explorer wouldn't work after reinstalling Files #6769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 7, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Fixed an issue where after reinstalling Files it was not possible to turn off the "Set Files As Default" option. The install/uninstall reg files were only copied when enabling the setting.

Validation
How did you test these changes?

  • Built and ran the app

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Copy necessary files also when unsetting files as default Fixed an issue where the option to reset the default file explorer wouldn't work after reinstalling Files Nov 7, 2021
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 7, 2021
@yaira2 yaira2 merged commit 1cdfbfc into files-community:main Nov 7, 2021
@gave92 gave92 deleted the issue_6729 branch November 7, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants