Skip to content

Refresh env variables when launching terminal #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 30, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Refresh env variables when launching a new terminal

Validation
How did you test these changes?

  • Built and ran the app

Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 1, 2021
@yaira2
Copy link
Member

yaira2 commented Nov 1, 2021

Thank you!

@yaira2 yaira2 merged commit c09b647 into files-community:main Nov 1, 2021
@gave92 gave92 deleted the issue_6634 branch November 1, 2021 14:06
Comment on lines +96 to +97
foreach (DictionaryEntry ent in Environment.GetEnvironmentVariables(EnvironmentVariableTarget.Machine))
process.StartInfo.EnvironmentVariables[(string)ent.Key] = (string)ent.Value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to avoid #14101?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal opened by Files doesn't update its environment variables with each launch
3 participants