Skip to content

ColumnView improvements #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 29, 2021
Merged

ColumnView improvements #6648

merged 9 commits into from
Oct 29, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 28, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Removed ~1000 lines of duplicate code between ColumnViewBrowser and ColumnViewBase
  • Toolbar buttons now work for all columns, not just the last

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 requested a review from winston-de October 28, 2021 22:42
yaira2
yaira2 previously approved these changes Oct 29, 2021
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Oct 29, 2021

@gave92 can you resolve the merge conflicts?

winston-de
winston-de approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@winston-de winston-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 29, 2021
yaira2
yaira2 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 0e7528f into files-community:main Oct 29, 2021
@yaira2 yaira2 mentioned this pull request Oct 29, 2021
Closed
@gave92 gave92 deleted the issue_6638 branch October 29, 2021 14:41
This was referenced Nov 5, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@winston-de winston-de winston-de approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files crashes when pressing Ctrl+L in column view
3 participants
@gave92 @yaira2 @winston-de