Skip to content

feat: Use Windows Terminal as initial default if present #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Conversation

lukeblevins
Copy link
Contributor

Resolved / Related Issues
Windows Terminal will now be used as the initial default, if installed.

Details of Changes
This change better supports users on Windows 11. Additionally, it slightly improved code quality in the TerminalController file.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

NOTE: Please test this PR on Windows 10 before merge.

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 28, 2021
@yaira2 yaira2 merged commit acb9596 into main Oct 29, 2021
@yaira2 yaira2 deleted the dev/lubl/wterm branch October 29, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants