Skip to content

Fix library update and list #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2021
Merged

Fix library update and list #6426

merged 2 commits into from
Oct 11, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 10, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested a review from winston-de October 10, 2021 21:50
@lukeblevins lukeblevins self-requested a review October 10, 2021 22:04
lukeblevins
lukeblevins approved these changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Thanks!

yaira2
yaira2 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 11, 2021
@yaira2 yaira2 merged commit 7b62c45 into files-community:main Oct 11, 2021
@yaira2 yaira2 mentioned this pull request Oct 11, 2021
Closed
@gave92 gave92 deleted the fix_libs branch October 11, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeblevins lukeblevins lukeblevins approved these changes

@yaira2 yaira2 yaira2 approved these changes

@jj-crypto jj-crypto jj-crypto approved these changes

@winston-de winston-de Awaiting requested review from winston-de

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing OneDrive folders from Libraries causing a crash
4 participants
@gave92 @lukeblevins @yaira2 @jj-crypto