Skip to content

Update font style #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 12, 2021
Merged

Update font style #5734

merged 13 commits into from
Aug 12, 2021

Conversation

winston-de
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Updated font style in details layout, grid view, and preview pane to use caption text style
  • added file tag to preview pane
  • Fix issue where right clicking text in rename box would commit rename
  • add part of set property
  • fix issue where tab item would not be selected on load
  • fix alignment issue with tags in tiles view

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
image

@yaira2 yaira2 requested a review from gave92 August 9, 2021 16:01
gave92
gave92 reviewed Aug 9, 2021
View reviewed changes
@yaira2 yaira2 requested a review from gave92 August 10, 2021 01:25
gave92
gave92 reviewed Aug 10, 2021
View reviewed changes
gave92
gave92 reviewed Aug 10, 2021
View reviewed changes
gave92
gave92 reviewed Aug 10, 2021
View reviewed changes
gave92
gave92 approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@gave92 gave92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 12, 2021
@yaira2 yaira2 merged commit 965e608 into main Aug 12, 2021
@yaira2 yaira2 deleted the dv_fixes_1 branch August 12, 2021 21:14
@yaira2 yaira2 mentioned this pull request Aug 12, 2021
Closed
@Darhagonable Darhagonable mentioned this pull request Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

@gave92 gave92 gave92 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disc Number is not displayed in properties of Music file
3 participants
@winston-de @gave92 @yaira2