Skip to content

Advanced search #4812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented May 1, 2021

Resolved / Related Issues
Add filters for the search bar.
Closes #4813

Details of Changes
Add a button after the searchbar, only visible when the searchbar is enabled.
The menu adds filter for the date.

More options will come later, but be careful not to overload the ui. The visual will be improved.

Screenshots (optional)
filter

@TailyFair
Copy link

Just an idea, but maybe filter should be in search results? Since you most likely would want to use this when initial search returns too many results?

@cinqmilleans
Copy link
Contributor Author

We can display the filter menu button on the results page and relaunch the filter when we modify.

@files-community files-community locked and limited conversation to collaborators May 2, 2021
@yaira2
Copy link
Member

yaira2 commented May 2, 2021

Please open an issue to discuss this change, once it's approved, the conversation here will be unlocked.

@files-community files-community unlocked this conversation May 3, 2021
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label May 6, 2021
@yaira2 yaira2 self-requested a review May 6, 2021 01:57
@cinqmilleans
Copy link
Contributor Author

@yaichenbaum Here is news of this issue. I am trying to imagine the best organization for the filter popup. This will take a few more days. Afterwards, I will post screenshots to validate the principle before implementation.

@cinqmilleans
Copy link
Contributor Author

This functionality has been replaced by #4813. So I close this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Changes are needed for this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add search filters
3 participants