Reduce scrolling stutters #3386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntObservableCollection
yaira2
approved these changes
Feb 1, 2021
yaira2
added
the
ready to merge
|
@hez2010 Thank you! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of SyncRoot to reduce unnecessary semaphores in BulkConcurrentObservableCollection.
I found there's no need to implement lock manually, there's already built-in
SyncRootfor this (inspired bySynchronizedCollection<T>).Fixes #3371
Note: it's no longer safe if you try to enumerate it without neither
lock (list.SyncRoot)nor.ToList()