Code Quality: Address all nullable and XAML compiler warnings - #18783
Code Quality: Address all nullable and XAML compiler warnings#18783hez2010 wants to merge 13 commits into
Conversation
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73b4c36bcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Preserve Current's invalid-state exception
When a caller reads Current before the first successful MoveNext(), after MoveNext() returns false, or after Reset(), this now returns default(T) or the stale last item instead of throwing InvalidOperationException as an IEnumerator<T> implementation must. This can silently expose invalid data to consumers that manually drive the enumerator; track whether the captured value is valid and retain the exception without re-indexing the mutable list.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
yair100
changed the title
|
Tested locally and didn't find any regression. |
0x5bfa
left a comment
0x5bfa
left a comment
There was a problem hiding this comment.
LGTM, code wise! Amazing work.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce9c7b109e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 participants
Addressed all nullable-related warnings and reworked the sidebar bindings a bit to address the AOT warnings from the XAML compiler as well.
Now thousands of warnings during build should gone. The remaining ones are usage to obsoleted APIs, which can be done separately.