-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature: Added default name when creating new files #17942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added default name when creating new files #17942
Conversation
|
@marlenhalvorsen it looks like this is missing the |
|
Subtitle added. “Enter an item name” now appears correctly in the create-item dialog. |
|
Thanks! Should we apply this change for other file formats as well? |
|
Thanks for the suggestion! I've looked into the handling of Because of this, only the folder case can receive a unique default label at the moment. Differentiating per file type (e.g. "New .pptx", "New .xlsx") would require passing additional ShellNewEntry/extension information into the dialog. |
yaira2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d61e5ca to
24ec2f9
Compare
Updated the create item dialog to prefill the input box with a default name for files and folders. Added a new resource string for file creation and modified dialog factory and UI helpers to support passing the item name. Update DynamicDialogFactory.cs
a686d11 to
2340848
Compare
|
@marlenhalvorsen thanks again for the PR. I know we discussed leaving this as is, but I decided to add support for other file formats for consistency. |
Issue:
Closes #17845
Changes:
Test steps: