Code Quality: Improved WindowsStorables #17191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
force-pushed
the
5bfa/CQ-WindowsStorable
branch
from
671e280 to
a9ef2a8
Compare
0x5bfa
commented
Jun 14, 2025
src/Files.App.Storage/Storables/WindowsStorage/WindowsStorable.cs
Outdated
Show resolved
Hide resolved
yaira2
previously approved these changes
Jun 15, 2025
|
yaira2
added
the
ready to merge
0x5bfa
force-pushed
the
5bfa/CQ-WindowsStorable
branch
from
6db3e1d to
b91982c
Compare
yaira2
force-pushed
the
main
branch
2 times, most recently
from
42c8207 to
4c7493f
Compare
0x5bfa
force-pushed
the
5bfa/CQ-WindowsStorable
branch
from
ecce5eb to
ddce4da
Compare
0x5bfa
commented
Jul 12, 2025
|
|
||
| // Invalid FOLDERID; this should never happen. | ||
| hr.ThrowOnFailure(); | ||
| } | ||
|
|
||
| ThisPtr = pItem; | ||
| ThisPtr = pShellItem; | ||
| } | ||
|
|
||
| public IAsyncEnumerable<IStorableChild> GetItemsAsync(StorableType type = StorableType.All, CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
Actual method used in the app is this, this is used in Quick Access widget. And in fact, other changes do not matter as don't used mostly.
0x5bfa
force-pushed
the
5bfa/CQ-WindowsStorable
branch
from
ddce4da to
60a0e3c
Compare
yaira2
reviewed
Jul 13, 2025
| @@ -13,6 +13,7 @@ namespace Files.App.Helpers | |||
| public static partial class Win32Helper | |||
| { | |||
| private static bool? isRunningOnArm = null; | |||
| [Obsolete] | |||
There was a problem hiding this comment.
Yes WindowsStorablesHelpers.IsOnArmProcessor @ WindowsStorablesHelpers.Process.cs which is newly created in this PR.
There was a problem hiding this comment.
Can we move the obsolete version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes