Skip to content
  • Rate limit · GitHub

    Access has been restricted

    You have triggered a rate limit.

    Please wait a few minutes before you try again;
    in some cases this may take up to an hour.

  • Notifications You must be signed in to change notification settings
  • Fork 2.3k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Hardcode .net version #16106

Merged
merged 14 commits into from
Sep 2, 2024
Merged

GitHub: Hardcode .net version #16106

merged 14 commits into from
Sep 2, 2024
Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 30, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yaira2 yaira2 force-pushed the ya/DotNetVersion branch 3 times, most recently from afb3ce4 to 6c9a2a8 Compare August 30, 2024 18:30
@yaira2
Copy link
Member Author

yaira2 commented Sep 1, 2024

@heftymouse is there a way to configure the .net version for the format action?

@0x5bfa
Copy link
Member

0x5bfa commented Sep 1, 2024

How about adding this to those two workflows?

    - name: Setup .NET 8
      uses: actions/setup-dotnet@v4
      with:
        dotnet-version: '8.0.303'

yaira2 and others added 4 commits August 31, 2024 22:54
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
@0x5bfa
Copy link
Member

0x5bfa commented Sep 1, 2024

#16116 helps with this PR

@yaira2 yaira2 requested a review from hishitetsu September 1, 2024 03:10
@yaira2 yaira2 self-assigned this Sep 1, 2024
@yaira2 yaira2 merged commit 46fccfe into main Sep 2, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 2, 2024
@yaira2 yaira2 deleted the ya/DotNetVersion branch September 2, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

3 participants