-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Added an action to open File Explorers property window #16031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in code quality, LGTM otherwise.
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
a11ced6
to
2cd9117
Compare
446e9b2
to
5603808
Compare
This reverts commit 5603808.
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For others referencing here: due to an issue with opening the shell property sheet from multiple selection (IShellFolder.GetUIObjectOf doesn't always work via Vanara), we decided to enable this option only when single item is selected. Future research may enable us to fix this issue. |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.