Skip to content

Code Quality: Improved performance of Git operations #14688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Feb 10, 2024

Changes

  • SemaphoreSlim is used instead of ThreadWithMessageQueue
  • Only GetRepositoryHead limits the number of concurrent operations. Limiting others may cause problems such as delay in displaying the item list.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Navigate to a Git repository from outside the repository.
    2. Navigate immediately to a subfolder of the repository.
    3. The delay in displaying items, which sometimes occurred especially in environments with weak networks, is now fixed.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 11, 2024
@yaira2 yaira2 merged commit d8b2bf7 into files-community:main Feb 11, 2024
@hishitetsu hishitetsu deleted the ImproveGitOperationPerformance branch February 11, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants